archipelago: auto-sync topology vertex count in set_topology to preve… - #626
Open
jschueller wants to merge 1 commit into
Open
archipelago: auto-sync topology vertex count in set_topology to preve…#626jschueller wants to merge 1 commit into
jschueller wants to merge 1 commit into
Conversation
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
The num_vertices_impl() fallback makes set_topology() non-terminating for existing custom topology UDAs that implement push_back() but not the new optional num_vertices(): every loop iteration still observes zero vertices. Either make vertex count part of the required topology concept or make the fallback track successful pushes, and add a legacy custom-topology regression.
…hang Calling set_topology() with a freshly constructed topology would replace the archipelago's topology with 0 vertices, crashing on evolve(). Fix by adding topology::num_vertices() and auto-growing via push_back(). For legacy custom UDAs that provide push_back() but not num_vertices(), the previous fallback returned 0, making the growth loop non-terminating. Fix by tracking successful push_back()s in topo_inner (m_fallback_vertices) and by bounding set_topology() to a fixed number of pushes. Add legacy regression covering both topology::num_vertices() fallback and archipelago::set_topology() with a legacy UDA. Fixes esa#606
Contributor
Author
|
@sylvesterkaczmarek, done, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt crash
Calling set_topology() with a freshly constructed topology (e.g. pagmo::topology(pagmo::ring())) would replace the archipelago's topology with one having 0 vertices, while the archipelago may already contain islands. Subsequent evolve() would then crash when get_connections() is called with an out-of-bounds vertex index.
Fix by adding a num_vertices() method to the topology class and modifying set_topology() to automatically call push_back() until the topology has enough vertices for all existing islands.
Fixes #606