fix(fix-plan): resolve full list-item block before toggling a sync marker - #378
Draft
daegunjhy wants to merge 1 commit into
Draft
fix(fix-plan): resolve full list-item block before toggling a sync marker#378daegunjhy wants to merge 1 commit into
daegunjhy wants to merge 1 commit into
Conversation
…rker sync.md's marker-toggle procedure only ever located an item by grepping a unique substring on its top-level line, so a nested ` - ` sub-bullet carrying its own independent marker and PR/Issue reference could be left unresolved after the parent was checked off. It also let the batch-query step's results be applied to a hand-picked subset of the extracted numbers instead of every one of them. Add a list-item block boundary step to Extract (step 1) plus two prohibition rows to the Sync-specific prohibitions table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/fix-plan --deepsync pass, an item was located by grepping a unique substring on its top-level- [ ]line and toggled to[x]without reading a directly-nested- [ ]sub-bullet immediately below it -- that sub-bullet carried its own independent PR reference and was left unresolved even though it had also already merged.sync.mdhad no explicit instruction to treat a nested sub-bullet as its own completion unit, and no instruction that batch-query results must be applied to every extracted number rather than a hand-picked subset.Changes
skills/fix-plan/sync.md: add a "List-item block boundary" step (with Don't/Do) to step 1 (Extract), and a new prohibition row to the Sync-specific prohibitions table.Test plan
bash scripts/lint-frontmatter.sh-- pre-existing unrelated failures only (resources/scripts/tests subdirs missing SKILL.md, confirmed present onnext-featbaseline before this change)pytest tests-- 103 passed, 4 skipped (pre-push hook, full run)bash tests/(bats) -- passed (pre-push hook)sync.md's existing style