fix(ci): use the real lcos_public CLI module - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: the CI workflow called
python -m lcos_toy.cli, but this repo shipslcos_publicand exposes the CLI aspython -m lcos_public.cliandlcos-public. The smoke step failed on GitHub withModuleNotFoundError: No module named 'lcos_toy'even though the test suite passed.\n\nChanges:\n- update the CI smoke step to uselcos_public.cli\n- add a regression test that pins the workflow to the real CLI module name\n\nVerification:\n-/tmp/lcos-venv/bin/python -m unittest tests.test_ci_workflow_cli -v\n-/tmp/lcos-venv/bin/python -m lcos_public.cli demo-ledger\n-/tmp/lcos-venv/bin/python -m lcos_public.cli demo-intake examples/requests/simple_accept.json\n-/tmp/lcos-venv/bin/python -m lcos_public.cli demo-route "summarize this audit receipt"\n-/tmp/lcos-venv/bin/python -m unittest discover -s tests -v