Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .credo.exs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
{Credo.Check.Readability.AliasOrder, []},
{Credo.Check.Readability.FunctionNames, []},
{Credo.Check.Readability.LargeNumbers, []},
{Credo.Check.Readability.MaxLineLength, [priority: :low, max_length: 120]},
{Credo.Check.Readability.ModuleAttributeNames, []},
{Credo.Check.Readability.ModuleDoc, []},
{Credo.Check.Readability.ModuleNames, []},
Expand Down Expand Up @@ -157,6 +156,9 @@
{Credo.Check.Warning.MixEnv, []},
{Credo.Check.Refactor.MapInto, []},

# Done by formatter
{Credo.Check.Readability.MaxLineLength, [priority: :low, max_length: 120]},

#
# Custom checks can be created using `mix credo.gen.check`.
#
Expand Down
14 changes: 13 additions & 1 deletion lib/sbom/cyclonedx.ex
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ defmodule SBoM.CycloneDX do
name: name,
group: component[:group],
version: component_version(component, schema_version),
versionRange: version_range(component),
purl: to_string(component.package_url),
Comment thread
maennchen marked this conversation as resolved.
scope: dependency_scope(component),
hashes: hashes,
Expand All @@ -325,6 +326,17 @@ defmodule SBoM.CycloneDX do
)
end

@spec version_range(component :: Fetcher.dependency()) :: String.t() | nil
defp version_range(component) do
with nil <- component[:version],
range when not is_nil(range) <- component[:version_requirement],
{:ok, vers} <- Version.Requirement.Vers.to_vers(range, "hex") do
vers
else
_version_or_no_range -> nil
end
end

@spec source_url_reference(
source_url :: String.t(),
schema_version()
Expand Down Expand Up @@ -577,7 +589,7 @@ defmodule SBoM.CycloneDX do
defp component_version(component, schema_version) do
case schema_version do
"1.3" -> component[:version] || component[:version_requirement] || "unknown"
# TODO: Handle VersionRequirement separately in 1.7+
"1.7" -> component[:version]
_schema_version -> component[:version] || component[:version_requirement]
end
end
Expand Down
1 change: 1 addition & 0 deletions lib/sbom/cyclonedx/xml/decodable.ex
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ defimpl Decodable,
{:group, :string, "child::group/text()"},
{:name, :string, "child::name/text()"},
{:version, :string, "child::version/text()"},
{:versionRange, :string, "child::versionRange/text()"},
{:description, :string, "child::description/text()"},
{:scope, :string, "child::scope/text()"},
{:hashes, {:list, hash_module}, "child::hashes/child::hash"},
Expand Down
2 changes: 1 addition & 1 deletion lib/sbom/cyclonedx/xml/encodable.ex
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ defimpl SBoM.CycloneDX.XML.Encodable,
{:group, :group, :wrap},
{:name, :name, :wrap},
{:version, :version, :wrap},
{:versionRange, :version_range, :wrap},
{:versionRange, :versionRange, :wrap},
{:description, :description, :wrap},
{:scope, :scope, :wrap},
{:hashes, :hashes, :wrap},
Expand Down
19 changes: 18 additions & 1 deletion lib/sbom/scm/hex/scm.ex
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,28 @@ defmodule SBoM.SCM.Hex.SCM do
^repository_url -> %{"repository_url" => repository_url}
end

{version, qualifiers} =
case {version, requirement} do
# Deps given as `{app, opts}` carry no requirement at all.
{nil, nil} ->
{nil, qualifiers}

{nil, requirement} ->
case {Version.parse(requirement), Version.Requirement.Vers.to_vers(requirement, "hex")} do
{{:ok, %Version{} = ver}, _vers} -> {to_string(ver), qualifiers}
{:error, {:ok, vers}} -> {nil, Map.put(qualifiers, "vers", vers)}
{:error, :error} -> {nil, qualifiers}
end

{version, _requirement} ->
{version, qualifiers}
end

Purl.new!(%Purl{
type: "hex",
namespace: hex_namespace(opts[:repo]),
name: opts |> Keyword.fetch!(:hex) |> to_string(),
version: version || requirement,
version: version,
qualifiers: qualifiers
})
end
Expand Down
Loading
Loading