Repository navigation
fix(items): a carried spell focus no longer blocks inventory completeness - #226
Merged
eriknihlen merged 1 commit intoOct 19, 2026
Conversation
…ness HasCompleteInventory wanted a contents listing for every container-slot item, but ACE never sends one for a focus (container type 2), since it holds nothing. Anyone carrying a focus never had a complete inventory, so plugin Sort waited 60 s and gave up. Skip foci when walking packs. Claude-Session: https://claude.ai/code/session_01Lm9T9oP2Hi5FEjwsLmXeyN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A character carrying a spell focus never had a complete inventory, so anything waiting on
HasCompleteInventory(plugin inventory sorting, the auto-vendor sell check) waited forever.ClientObjectTable.HasCompleteInventorywants a contents listing for the owner and for every item in a container slot. A focus (container type 2) takes a container slot, but the server never sends a contents listing for one, since a focus holds nothing. So the walk never finished. It now skips foci, using the existingInventoryContainerPlacementPolicy.IsFocus, which already treats a focus as holding nothing. Packs and nested packs still have to be listed.Test:
InventoryCompletenessTests.SpellFocusNeverListedDoesNotBlockCompleteness. A manifest with a pack (type 1) and a focus (type 2) is not complete until the pack is listed, then complete with the focus never listed. It fails without the fix.Verified live: a plugin inventory sort on a character carrying a focus used to stop after 60 s with "the inventory never finished loading"; with the fix it runs.
Original behavior
Client-side bookkeeping only; nothing the client does in the world changes. The server sends no contents listing for a focus, as seen on a live server: the focus appears in the login container list, and its listing never arrives.
Checklist
dotnet build AcDream.slnx -c Releaseis greenhttps://claude.ai/code/session_01Lm9T9oP2Hi5FEjwsLmXeyN