Repository navigation
Plugin markup tabs can show an icon - #213
Merged
Merged
Conversation
<tab> takes the same icon and iconkind attributes as <button>. The tab already draws an icon through UiSimpleButton, so the parser now reads the pair through one shared helper for both controls. Claude-Session: https://claude.ai/code/session_01SY57mHJLZ6djpWZ5nP37Tw
A tab's caption already mutes when the tab is not selected; its icon now recedes with it. UiSimpleButton draws its icon through an IconTint the tab overrides, so buttons keep drawing their icons as authored. Claude-Session: https://claude.ai/code/session_01SY57mHJLZ6djpWZ5nP37Tw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin markup
<tab>can now show an icon, using the same attributes as<button>:iconis a literal or a binding;iconkindisdid(default),spelloritem, exactly as on buttons.textgives an icon-only tab.UiMarkupTabButtonalready inheritsUiSimpleButton's icon drawing, so most of the change is in the parser. Buttons and tabs now readicon/iconkindthrough one shared helper, andUiSimpleButtongains an overridableIconTintthat the tab uses for the dimming.Tests:
MarkupIconTestscovers tab icon dispatch, bound re-reads, the no-icon case, build-time errors for a badiconkindor binding, and the selected/unselected icon alpha.docs/plugin-ui-markup.mdlists the new attributes.Note: on current
main, a clean restore fails NuGet audit on the October SixLabors.ImageSharp advisories (NU1902/NU1903 as errors). I built and tested this branch with-p:NuGetAudit=false. The App test failures with that flag are the same with and without this change (installed-DAT lanes only).https://claude.ai/code/session_01SY57mHJLZ6djpWZ5nP37Tw