fix: inflate the Android splash icon on API 29/30 - #165
Open
KonradIT wants to merge 1 commit into
Open
Conversation
`installSplashScreen()` threw `Resources$NotFoundException` before the
first frame on every minSdk device: `opc_splash_empty` was a `<vector>`
carrying only a comment, and `VectorDrawable.inflateChildElements`
rejects a vector with no `<path>` ("no path defined"). API 31+ draws the
splash in the platform and never inflates the icon, so the crash was
invisible above API 30 and to lint and unit tests.
Give the vector one fully transparent path. The hold stays invisible, so
the splash still never flashes a square logo.
Crash reproduced on a physical MI_PAD_4 (Android 10, API 29, arm64-v8a).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installSplashScreen()threwResources$NotFoundExceptionbefore the first frame on every minSdk device:opc_splash_emptywas a<vector>carrying only a comment, andVectorDrawable.inflateChildElementsrejects a vector with no<path>("no path defined"). API 31+ draws the splash in the platform and never inflates the icon, so the crash was invisible above API 30 and to lint and unit tests.Give the vector one fully transparent path. The hold stays invisible, so the splash still never flashes a square logo.
Crash reproduced on a physical MI_PAD_4 (Android 10, API 29, arm64-v8a).
App works fine on Pixel 10.
What & why
TestFlight notes
Checklist
just checkpasses.just native-checkpasses, or the relevant platform check is noted.ios/TestFlight/WhatToTest.en-US.txtcopy.MARKETING_VERSIONinios/Config/Version.xcconfigwhen starting a new version train.