fix(ci): rebuild the MCP bundle so main is green again - #281
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3668aec0-3ef2-485c-b402-7fe7684f870b) |
… green The committed packages/sanction-mcp/mcp-server.js drifted from source when #270/#273 bumped the bundled MCP SDK; the freshness step has failed every push to main since. Rebuilt with npm run build:mcp, no source change. Second time this has happened after a dependabot batch (#263 was the first) — the dependabot bumps should rebuild the bundle in the same PR. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
520cb2c to
226feff
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_27078a26-9991-48a6-9ab9-6a4a1d5df59f) |
Why
Every push to
mainsince the dependency batches (#270, #273) fails CI at MCP bundle freshness: the committedpackages/sanction-mcp/mcp-server.jsno longer matches whatnpm run build:mcpproduces, because the bundled@modelcontextprotocol/sdkchanged. All five sprint PRs inherited the redbuildjob from main. Same failure mode as #263.What
npm run build:mcp, commit the artifact. No source change.Follow-up worth queuing
Dependabot batches that touch
@modelcontextprotocol/sdk(or anything bundled) should rebuild the bundle in the same PR, or the freshness job should run the rebuild and commit it on dependabot branches. Otherwise main goes red after every SDK bump.🤖 Generated with Claude Code
Note
Low Risk
Bundled SDK refresh with stricter stdin buffering and richer validation errors; low risk unless clients send very large stdio payloads or depend on the old single-issue error text.
Overview
Refreshes the committed
packages/sanction-mcp/mcp-server.jsartifact so it matchesnpm run build:mcpand CI’s bundle-freshness check passes after the bundled@modelcontextprotocol/sdkmoved forward—no app source edits.The new SDK bits in the bundle add stdio read hardening:
ReadBufferenforces a default 10 MB cap (configurable via transport options), andStdioServerTransportsurfaces append failures throughonerrorand closes the transport. Tool/request validation errors now list all Zod issues with dot-path locations instead of only the first message.setRequestHandlerreads the RPC method literal via sharedgetLiteralValueinstead of duplicated Zod v3/v4 extraction.Reviewed by Cursor Bugbot for commit 226feff. Bugbot is set up for automated code reviews on this repo. Configure here.