Skip to content

fix(ci): rebuild the MCP bundle so main is green again - #281

Merged
ericlovold merged 1 commit into
mainfrom
fix/mcp-bundle-freshness
Sep 2, 2026
Merged

fix(ci): rebuild the MCP bundle so main is green again#281
ericlovold merged 1 commit into
mainfrom
fix/mcp-bundle-freshness

Conversation

@ericlovold

@ericlovold ericlovold commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Why

Every push to main since the dependency batches (#270, #273) fails CI at MCP bundle freshness: the committed packages/sanction-mcp/mcp-server.js no longer matches what npm run build:mcp produces, because the bundled @modelcontextprotocol/sdk changed. All five sprint PRs inherited the red build job from main. Same failure mode as #263.

What

npm run build:mcp, commit the artifact. No source change.

Follow-up worth queuing

Dependabot batches that touch @modelcontextprotocol/sdk (or anything bundled) should rebuild the bundle in the same PR, or the freshness job should run the rebuild and commit it on dependabot branches. Otherwise main goes red after every SDK bump.

🤖 Generated with Claude Code


Note

Low Risk
Bundled SDK refresh with stricter stdin buffering and richer validation errors; low risk unless clients send very large stdio payloads or depend on the old single-issue error text.

Overview
Refreshes the committed packages/sanction-mcp/mcp-server.js artifact so it matches npm run build:mcp and CI’s bundle-freshness check passes after the bundled @modelcontextprotocol/sdk moved forward—no app source edits.

The new SDK bits in the bundle add stdio read hardening: ReadBuffer enforces a default 10 MB cap (configurable via transport options), and StdioServerTransport surfaces append failures through onerror and closes the transport. Tool/request validation errors now list all Zod issues with dot-path locations instead of only the first message. setRequestHandler reads the RPC method literal via shared getLiteralValue instead of duplicated Zod v3/v4 extraction.

Reviewed by Cursor Bugbot for commit 226feff. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sanction Ready Ready Preview Sep 2, 2026 5:57pm UTC

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ee5efa68-b5bd-4b3f-bcc1-c09e3b258cf9


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_3668aec0-3ef2-485c-b402-7fe7684f870b)

… green

The committed packages/sanction-mcp/mcp-server.js drifted from source when
#270/#273 bumped the bundled MCP SDK; the freshness step has failed every push
to main since. Rebuilt with npm run build:mcp, no source change. Second time
this has happened after a dependabot batch (#263 was the first) — the
dependabot bumps should rebuild the bundle in the same PR.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ericlovold
ericlovold force-pushed the fix/mcp-bundle-freshness branch from 520cb2c to 226feff Compare September 2, 2026 17:57
@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_27078a26-9991-48a6-9ab9-6a4a1d5df59f)

@ericlovold
ericlovold merged commit a776357 into main Sep 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant