Skip to content

Fix the four blocking findings from PR #268's review #270

Closed

Description

@ericlitman

Current scope

Unfret's verdict on PR #268 head 0087ba6 raised four blocking findings. Classes (batch owner, 2026-11-06):

  1. v1:233d6c57… verdict-changing: the verifier's setup configure case compares setting lines as an exact singleton, but settingLines now returns every provider's line and the case's preparation removes only Codex's. A sheet with another provider's writer line fails the live gate.
  2. v1:857b2c9a… verdict-changing: writers is not in the shared-recipe expansion in .claude/skills/verify-open-pstack/scripts/core.ts, so a PR that changes only features/recipes.ts cannot name writers.
  3. v1:35b3cceb… verdict-changing: agy's catalog note (from registry/providers.ts) still names the agent pstack-read-only after the rename to pstack-lane, and still says the lane's tools are removed, which 1.5.2 contradicts.
  4. v1:577bc17a… fails-loudly: setup accepts <provider> writer sandbox: full-access for a provider whose adapter declares no full-access writer (dsh, Grok, Claude); the runner refuses it at dispatch.

Acceptance:

  • Items 1 to 3 fixed with the smallest change; items 1 and 2 each get the test the finding's scenario needs.
  • Item 4 gets no repair: the runner refuses the lane at dispatch, so nothing writes unconfined. It is recorded with its class only.
  • Advisories (stale agy command, Muse unavailable-model details, docs/reference.md version) may be fixed in the same diff only if they touch the same lines.

Introduced by: #268

Activity

  1. ericlitman commented on Nov 6, 2026

    @ericlitman
    OwnerAuthor

    PR: #271

  2. added a commit that references this issue on Nov 6, 2026
  3. ericlitman commented on Nov 6, 2026

    @ericlitman
    OwnerAuthor

    Batch 262 closeout for this issue (full record: https://github.com/mobilyze-llc/docs/blob/main/projects/open-pstack/records/2026-11-06-batch-262/closeout.md):

    #270: three verdict-changing findings from PR #268

    Fix-forward PR #271, merged head 4e28148 approved. Configure case accepts other providers' setting lines, writers reachable from a recipes-only change, agy's catalog note names pstack-lane and the 1.5.2 tool surface; items 1 and 2 have tests that fail before and pass after. Item 4 recorded as fails-loudly with no repair. The repair record misplaced agy's note in registry/providers.ts; it is in providers/agy.ts. Live: claude:setup and codex:catalog with self-test, on pro14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions