Extend climate to include preset mode and fan swing modes - #7
Open
ajayramaswamy wants to merge 1 commit into
Open
Extend climate to include preset mode and fan swing modes#7ajayramaswamy wants to merge 1 commit into
ajayramaswamy wants to merge 1 commit into
Conversation
following the changes listed here https://github.com/litinoveweedle/SmartIR and the comments here litinoveweedle/SmartIR#79 also ruff and uv have cleaned up the formatting.
Owner
|
Hey sorry didint take a look at this in a while! As much as I love the formatting changed you added, it makes it pretty difficult to review this and ensure its not broken.. I dont currently have the time to test this and would prefer not breaking this for others. Can you confirm it was working at the time of your changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following the changes listed here
https://github.com/litinoveweedle/SmartIR
and the comments here
litinoveweedle/SmartIR#79
also ruff and uv have cleaned up the formatting.