Conversation
wdonet
approved these changes
Jan 29, 2021
| <div className="App"> | ||
| <h1>Welcome to your second mini challenge!</h1> | ||
| <div className="pokemonsContainer"> | ||
| <PokeCard pokemonData={mockPokemonData} /> |
There was a problem hiding this comment.
Since there are not much elements inside the mocked data, you could send them as properties for having the code more descriptive itself
Suggested change
| <PokeCard pokemonData={mockPokemonData} /> | |
| const { name, sprites, video } = mockPokemonData; | |
| <PokeCard sprites={sprites} name={name} video={video} /> |
| <img src={props.pokemonData.sprites.front_shiny} alt="Shiny" /> | ||
| </div> | ||
| <div className="pokemonControls"> | ||
| <a href={props.pokemonData.video} target="blank"> |
There was a problem hiding this comment.
Following what I said before, it makes the code cleaner here using less navigation through the pokemon obj.
Suggested change
| <a href={props.pokemonData.video} target="blank"> | |
| PokeCard({ name, sprites, video }) | |
| <a href={video} target="_blank" rel="noreferrer"> |
I know it is not much visible with this case but you'll see it for sure in more complex components.
| width: 100%; | ||
| } | ||
|
|
||
| .pokemonImages img { |
There was a problem hiding this comment.
nice 👌🏽 that you took care of the styling
Destructuring mockPokemonData and pass properties separated to the PokeCard component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.