perf: optimize craft get with repo/tree caching and parallel resolution#32
Merged
Conversation
- Cache *git.Repository objects in GoGitFetcher to eliminate redundant lock+open+fetch cycles (7-9× per dep reduced to 1×) - Cache ListTree results to avoid redundant tree walks between resolution and install phases - Parallelize Phase 4 (resolveOne loop) with errgroup so independent dependencies resolve concurrently - Add defensive copy for cached tree slices to prevent mutation - Cache memory clones for nil-cache path to deduplicate concurrent requests Estimated 7-10× speedup for typical multi-dependency workloads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes
craft getperformance with three complementary changes that together yield an estimated 7-10× speedup for typical multi-dependency workloads.Changes
1. Repository object caching (
internal/fetch/gogit.go)GoGitFetchernow caches*git.Repositoryobjects in memoryResolveRef,ReadFiles, andListTreecall triggered a fullensureRepo()cycle: acquire file lock → open repo → git fetch → return → release lock2. ListTree result caching (
internal/fetch/gogit.go)ListTree()results are cached by(url, commitSHA)key3. Parallel dependency resolution (
internal/resolve/resolver.go)resolveOne()loop now useserrgroup.Groupfor concurrent executionresolveOne()call is independent (different dep, read-only options, no shared mutable state)golang.org/x/syncdependencyPerformance Impact
ensureRepo()calls per depTesting
go test -race ./...)