Skip to content

Support resdata 6 and 7 GRDECL writers - #967

Merged
ajaust merged 1 commit into
equinor:mainfrom
ajaust:fix-cwrap-open
Sep 2, 2026
Merged

Support resdata 6 and 7 GRDECL writers#967
ajaust merged 1 commit into
equinor:mainfrom
ajaust:fix-cwrap-open

Conversation

@ajaust

@ajaust ajaust commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Use the legacy cwrap file interface for resdata 6 and a standard text stream for resdata 7 and later.

Tested locally with resdata@main

@ajaust

ajaust commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

If we are happy with the changes, I will open an issue to track the compatibility fixes introduced to support resdata<7 and resdata>=7 at the same time. Once resdata>=7 is published, we can bump the resdata version required by semeio and stick to resdata's new API.

@ajaust
ajaust marked this pull request as ready for review September 2, 2026 07:28
@ajaust
ajaust marked this pull request as draft September 2, 2026 07:31
Use the legacy cwrap file interface for resdata 6 and a standard text
stream for resdata 7 and later. packaging was a transient dependency and
becomes an explicit dependency.
@ajaust
ajaust marked this pull request as ready for review September 2, 2026 07:35
@ajaust ajaust added this to SCOUT Sep 2, 2026
@ajaust ajaust moved this to In Progress in SCOUT Sep 2, 2026
@ajaust ajaust added maintenance dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code labels Sep 2, 2026
@ajaust ajaust moved this from In Progress to Fast Track in SCOUT Sep 2, 2026

@andreas-el andreas-el left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 💪

@github-project-automation github-project-automation Bot moved this from Fast Track to Reviewed in SCOUT Sep 2, 2026
@ajaust
ajaust merged commit 76ae270 into equinor:main Sep 2, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Sep 2, 2026
@ajaust

ajaust commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Created issue to track these changes: #968

@ajaust
ajaust deleted the fix-cwrap-open branch September 2, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance python:uv Pull requests that update python:uv code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants