fix: allow no schedulerPort if atleast one cron schedule is defined - #1833
Draft
Richard87 wants to merge 2 commits into
Draft
Conversation
…all envs must be valid)
| errs = append(errs, fmt.Errorf("environment %s: %w", env.Name, ErrSchedulerPortOrCronRequiredForJob)) | ||
| } | ||
| } | ||
| return errs |
Contributor
There was a problem hiding this comment.
Suppose the job does not have scheduler port or cron schedule, in addition to not being enabled in any environment. Currently it would return an empty slice of errors. Should we instead return ErrSchedulerPortOrCronRequiredForJob?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all enabled environments are valid in cases of env override