Skip to content

fix: remove setting shared-secret in register application endpoint #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richard87 wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −7
Open

fix: remove setting shared-secret in register application endpoint #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d7abe5
fix: remove setting shared-secret upfront
Richard87 Jul 6, 2026
57658df
fix: remove shared-secret option from create application command
Richard87 Jul 31, 2026
ba2fd14
fix: remove shared-secret parameter from application creation command
Richard87 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cmd/createApplication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,14 @@ var createApplicationCmd = &cobra.Command{
Use: "application",
Short: "Create application",
Long: "Creates a Radix application in the cluster",
Example: `rx create application --application your-application-name --repository https://github.com/your-repository --config-branch main --ad-groups abcdef-1234-5678-9aaa-abcdefgf --reader-ad-groups=23456789--9123-4567-8901-23456701 --shared-secret someSecretPhrase12345 --acknowledge-warnings --configuration-item "YOUR PROJECT CONFIG ITEM" --context playground`,
Example: `rx create application --application your-application-name --repository https://github.com/your-repository --config-branch main --ad-groups abcdef-1234-5678-9aaa-abcdefgf --reader-ad-groups=23456789--9123-4567-8901-23456701 --acknowledge-warnings --configuration-item "YOUR PROJECT CONFIG ITEM" --context playground`,
RunE: func(cmd *cobra.Command, args []string) error {
appName, err := config.GetAppNameFromConfigOrFromParameter(cmd, flagnames.Application)
if err != nil {
return err
}

repository, _ := cmd.Flags().GetString(flagnames.Repository)
sharedSecret, _ := cmd.Flags().GetString(flagnames.SharedSecret)
configBranch, _ := cmd.Flags().GetString(flagnames.ConfigBranch)
configFile, _ := cmd.Flags().GetString(flagnames.ConfigFile)
configurationItem, _ := cmd.Flags().GetString(flagnames.ConfigurationItem)
Expand Down Expand Up @@ -78,7 +77,6 @@ var createApplicationCmd = &cobra.Command{
RadixConfigFullName: configFile,
ReaderAdGroups: readerAdGroups,
Repository: &repository,
SharedSecret: &sharedSecret,
},
})

Expand Down Expand Up @@ -143,7 +141,6 @@ func init() {
createCmd.AddCommand(createApplicationCmd)
createApplicationCmd.Flags().StringP(flagnames.Application, "a", "", "Name of the application to create")
createApplicationCmd.Flags().StringP(flagnames.Repository, "", "", "The GitHub repository URL")
createApplicationCmd.Flags().StringP(flagnames.SharedSecret, "", "", "(Optional) Shared secret for the webhook. It is needed when use a GitHub webhook.")
createApplicationCmd.Flags().StringP(flagnames.ConfigBranch, "", "", "Name of the branch where Radix will read your radixconfig.yaml from")
createApplicationCmd.Flags().StringP(flagnames.ConfigFile, "", "", "(Optional) Name of the radix config file. Defaults to radixconfig.yaml")
createApplicationCmd.Flags().StringSliceP(flagnames.AdminADGroups, "", []string{}, "Admin groups (UUIDs of Microsoft Entra groups). Optional for the Playground context")
Expand Down
3 changes: 1 addition & 2 deletions hack/setup_application.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ PUBLIC_KEY=$(rx create application \
--token-environment \
--from-config \
--repository $REPOSITORY \
--owner $OWNER \
--shared-secret $SHARED_SECRET 2>&1)
--owner $OWNER 2>&1)

# Wait for application to be reconciled
sleep 3
Expand Down
1 change: 0 additions & 1 deletion pkg/flagnames/names.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ const (
Repository = "repository"
Schema = "schema"
Secret = "secret"
SharedSecret = "shared-secret"
Since = "since"
SkipValidation = "skip-validation"
StrictValidation = "strict-validation"
Expand Down