ENH: Add project validation metadata#288
Merged
GibranAlfa merged 2 commits intoJun 29, 2026
Merged
Conversation
GibranAlfa
marked this pull request as ready for review
June 25, 2026 13:56
slangeveld
approved these changes
Jun 29, 2026
| """Timestamp when the data was last validated.""" | ||
|
|
||
| last_validated_by: str | ||
| """User who performed the validation.""" |
Collaborator
There was a problem hiding this comment.
This should probably be "User who performed the last validation" to be alligned with docstring for last_validated_at
GibranAlfa
force-pushed
the
add-project-validation-metadata
branch
from
June 29, 2026 09:50
4c9eb1d to
b79e922
Compare
GibranAlfa
force-pushed
the
add-project-validation-metadata
branch
from
June 29, 2026 09:50
b79e922 to
23a4319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #58
Added project config validation metadata so API can record when saved project data was last checked against external/project sources.
This adds:
ValidationRecord, withlast_validated_atandlast_validated_byProjectValidation, withmasterdata_smdaandrms_projectProjectConfig.validation, defaulting to empty validation metadataExample serialized shape:
{ "validation": { "masterdata_smda": { "last_validated_at": "2026-06-25T10:30:00Z", "last_validated_by": "muga" }, "rms_project": { "last_validated_at": "2026-06-25T10:31:00Z", "last_validated_by": "muga" } } }Empty/default shape:
{ "validation": { "masterdata_smda": null, "rms_project": null } }The API would fill them like this:
Checklist
--cov=src/ --cov-report term-missing)