Skip to content

ENH: Populate uuid in .fmu#286

Merged
nourinmohd merged 3 commits into
equinor:mainfrom
nourinmohd:285_populate_uuid
Jun 24, 2026
Merged

ENH: Populate uuid in .fmu#286
nourinmohd merged 3 commits into
equinor:mainfrom
nourinmohd:285_populate_uuid

Conversation

@nourinmohd

@nourinmohd nourinmohd commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Resolves #285

Populates stratigraphy UUIDs when building global config stratigraphy.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@nourinmohd

Copy link
Copy Markdown
Contributor Author

The relevant tests needs to be updated but when I did it first I got this error :

{'TopX': {'name': 'X Fm. Top', 'stratigraphic': True}}
{'TopX': {'name': 'X Fm. Top', 'stratigraphic': True, 'uuid': '00000000-0000-0000-0000-000000000001'}}

I think its because it's not pulling the latest fmu-datamodels ?

@nourinmohd
nourinmohd force-pushed the 285_populate_uuid branch 2 times, most recently from f0323e0 to 124f4aa Compare June 24, 2026 12:02
Comment thread pyproject.toml Outdated
Comment thread src/fmu/settings/_resources/mappings_manager.py
Comment thread pyproject.toml Outdated

@GibranAlfa GibranAlfa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should still pin fmu-datamodels to minimum 0.23.1 because lower version will break current implementation

@tnatt tnatt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I agree it should be pinned 👍

@nourinmohd
nourinmohd merged commit 51369b0 into equinor:main Jun 24, 2026
9 checks passed
@nourinmohd
nourinmohd deleted the 285_populate_uuid branch June 24, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support UUID propagation from .fmu stratigraphic SMDA mappings into metadata

3 participants