ENH: Populate uuid in .fmu#286
Merged
Merged
Conversation
nourinmohd
force-pushed
the
285_populate_uuid
branch
from
June 24, 2026 11:48
8bd8a27 to
4964d00
Compare
Contributor
Author
|
The relevant tests needs to be updated but when I did it first I got this error : I think its because it's not pulling the latest fmu-datamodels ? |
nourinmohd
force-pushed
the
285_populate_uuid
branch
2 times, most recently
from
June 24, 2026 12:02
f0323e0 to
124f4aa
Compare
nourinmohd
force-pushed
the
285_populate_uuid
branch
from
June 24, 2026 12:05
124f4aa to
2ee712e
Compare
nourinmohd
commented
Jun 24, 2026
GibranAlfa
reviewed
Jun 24, 2026
GibranAlfa
approved these changes
Jun 24, 2026
GibranAlfa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I think we should still pin fmu-datamodels to minimum 0.23.1 because lower version will break current implementation
tnatt
approved these changes
Jun 24, 2026
tnatt
left a comment
Contributor
There was a problem hiding this comment.
Nice! I agree it should be pinned 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #285
Populates stratigraphy UUIDs when building global config stratigraphy.
Checklist
--cov=src/ --cov-report term-missing)