style: apply lint fixes and improve formatting in scripts and docs#111
Merged
Conversation
rnyb
commented
May 29, 2026
rnyb
commented
Collaborator
- Update YAML formatting and action versions in test workflow
- Fix typos and improve grammar in README
- Reorder imports and adjust docstring formatting in Python scripts
- Improve line wrapping and whitespace consistency
- Remove unused variable and redundant imports
There was a problem hiding this comment.
Pull request overview
This PR focuses on style/lint-driven cleanup across Python scripts, documentation, and CI configuration to improve consistency and readability.
Changes:
- Reformat and modernize the GitHub Actions test workflow (indentation, caching, additional Ruff checks).
- Apply formatting/import cleanups in Python scripts and adjust docstring/comment wrapping.
- Fix typos/grammar in the README and improve wording.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sim2seis/bin/run_multi_pem.py |
Reorders imports and removes an unused import from open_petro_elastic.__main__. |
README.md |
Fixes typos/grammar and refines the license section text/wording. |
ert/bin/scripts/fm_xsect_wells.py |
Reorders imports and rewraps the DESCRIPTION text and a long comment. |
ert/bin/scripts/fm_lgr.py |
Removes an unused variable and rewraps long string literals; updates expected test output strings. |
.github/workflows/test.yml |
YAML formatting tweaks, enables pip caching, and adds ruff check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rnyb
force-pushed
the
lint-fixes
branch
3 times, most recently
from
May 29, 2026 13:27
1f35e9a to
8edb54c
Compare
- Update YAML formatting and action versions in test workflow - Fix typos and improve grammar in README - Reorder imports and adjust docstring formatting in Python scripts - Improve line wrapping and whitespace consistency - Remove unused variable and redundant imports
- Replace manual file open/close with context managers for safety - Simplify boolean checks and variable names for clarity - Fix typo in argument help string - Remove redundant code and streamline file operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.