Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Drogon AHM ERT configuration to use zone-specific ERTBOX grids for APS field parameters, enabling different grid sizes per zone (as described in Issue #103) to reduce memory/disk/runtime when layer counts vary significantly between zones.
Changes:
- Updated APS field parameter configuration to reference separate ERTBOX EGRID files per zone (Valysar/Therys/Volon) and bind each FIELD parameter to the appropriate grid.
- Updated the main AHM ERT model include comment to reflect the new per-zone ERTBOX behavior.
- Cleaned up the RMS project readme instructions for compress/restore and dev update steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rms/model/0readme.txt |
Reformats/clarifies instructions for compressing/restoring the RMS project and documenting dev updates. |
ert/model/drogon_ahm.ert |
Updates the comment on the APS include to indicate per-zone ERTBOX usage. |
ert/input/config/ahm_field_aps.ert |
Introduces per-zone EGRID definitions and assigns each APS FIELD parameter to the correct zone-specific ERTBOX grid via GRID:. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #103
This resolves the ERT part of the issue
The issue can be closed with next RMS update