remove args searchpath and sumo_env from sumo_upload#104
Merged
Conversation
Collaborator
|
Could we safely remove these as part of same PR? fmu-drogon/ert/model/drogon_dst.ert Line 118 in be21b5f |
Contributor
Author
This makes sense at least for me, what do you think @equinor/sudo |
Yes, those should be fine to remove as well. |
Collaborator
|
Just add me as reviewer if it is ready |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searchpath and sumo_env are no longer needed in sumo_upload, when provided we get a future warning, so suggest to remove it from here.