Add new observation file with localization data but not yet used in ERT configuration file#101
Merged
Merged
Conversation
rnyb
approved these changes
Mar 25, 2026
There was a problem hiding this comment.
Pull request overview
Adds an alternative Drogon observation set that includes per-observation localization metadata, and documents how to enable distance-based localization in the AHM ERT configuration.
Changes:
- Added a new observations file containing
LOCALIZATION { EAST/NORTH/RADIUS }blocks for summary observations. - Added (commented) configuration line intended to enable
DISTANCE_LOCALIZATIONin the AHM ERT config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ert/model/drogon_ahm.ert |
Adds a commented-out ANALYSIS_SET_VAR ... DISTANCE_LOCALIZATION line near the observations section. |
ert/input/observations/drogon_wbhp_rft_wct_gor_tracer_plt_local.obs |
Introduces a new observation file variant with localization coordinates/radii embedded in summary observations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rnyb
self-requested a review
March 25, 2026 13:09
rnyb
requested changes
Mar 25, 2026
rnyb
left a comment
rnyb
left a comment
Collaborator
There was a problem hiding this comment.
We should consider updating according to the copilot feedback. Especially for the use of new RFT_OBSERVATION
oddvarlia
force-pushed
the
add_localization_summary_obs
branch
3 times, most recently
from
April 9, 2026 13:18
cd8b502 to
f1ac7b6
Compare
oddvarlia
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rnyb
approved these changes
Apr 13, 2026
…tivate Distance-based localization
oddvarlia
force-pushed
the
add_localization_summary_obs
branch
from
April 21, 2026 12:21
f1ac7b6 to
b0ddf3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file with summary observations with localization data is added. The file is not per today used in the config file.