DEP: Deprecate warning for ExportData.fmu-context#1784
Open
nourinmohd wants to merge 1 commit into
Open
Conversation
nourinmohd
force-pushed
the
1513_deprecate_exportdata_notice
branch
from
July 2, 2026 18:37
28a29ed to
0c77671
Compare
tnatt
reviewed
Jul 3, 2026
Comment on lines
+361
to
+366
| if ( | ||
| preprocessed | ||
| and fmu_context_input is None | ||
| and effective_context == FMUContext.realization | ||
| ): | ||
| effective_context = FMUContext.case |
Collaborator
There was a problem hiding this comment.
You should not need to the fmu_context_input here, if fmu_context_input was None the effective_context was set from environment. So this should be enough
Suggested change
| if ( | |
| preprocessed | |
| and fmu_context_input is None | |
| and effective_context == FMUContext.realization | |
| ): | |
| effective_context = FMUContext.case | |
| if ( | |
| preprocessed | |
| and effective_context == FMUContext.realization | |
| ): | |
| effective_context = FMUContext.case |
Another note, the change here would essentially allow all realizations running in parallell to export to the same file, so might cause problems..
I know we have an error saying preprocessed should be run outside of ERT or with context case... but this seems wrong to me, preprocessed is only intended to be run outside of an ERT run, and then to be included into the run by the COPY_PREPROCESSED ERT workflow. Hence I struggle to see the use case for supporting case context here.
Could we make an issue to deprecate preprocessed in case context? 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1513
Checklist
--cov=src/ --cov-report term-missing)