docs: add ADR 0012 — pinned prerelease versioning for beta lines - #5196
docs: add ADR 0012 — pinned prerelease versioning for beta lines#5196pomfrida wants to merge 1 commit into
Conversation
|
@claude review |
|
Claude finished @pomfrida's task in 1m 4s —— View job Review: ADR 0012 — pinned prerelease versioningDocs-only change. I verified every technical claim in the ADR against the repo, and the ADR is accurate. Summary and details below.
Verification ✅The config the ADR describes matches
All three referenced targets exist: Findings1. Broken relative link to ADR-0011 at merge time (lines 9, 62-ish, 93) The ADR links Not a blocker (the PR body flags the merge-order dependency), just make sure the two land consistently. 2. "Status: Proposed" vs. an already-implemented, production-validated config (lines 3, 83, 88–89) The header says Proposed, but the Confirmation section states the config is merged and validated in production ( Nits (non-blocking)
VerdictClear, well-structured, and technically correct. The only actionable item is the relative link to a not-yet-existing ADR-0011 — verify the slug matches #5195 so the links resolve once both merge. Everything else is optional polish. |
Closes #5198
Summary
Records the versioning decision implemented in #5180 (eds-tokens) and #5190 (eds-core-react-next): both beta lines use release-please's
versioning: "prerelease"+prerelease: trueso the base stays pinned at3.0.0-beta.Nand every commit type only bumps the counter. Captures the non-obvious parts that live only in PR descriptions today:prerelease-type: betaalone does not pin the base — withoutprerelease: true, afixon3.0.0-beta.0releases stable3.0.0(the exact drift from fix: pin EDS 2.0 beta releases to a fixed 3.0.0-beta.N series #5141)release-type: simple(version.txt) —pnpm publishrewritesworkspace:^frompackage.json, which must stay on the stable version!in beta commits" rule is invertedNotes
3.0.0-beta.0 → 3.0.0-beta.1on 2026-07-20).🤖 Generated with Claude Code