ValueError: list.remove(x): x not in list - #240
Open
thomie wants to merge 1 commit into
Open
Conversation
There is a bug in `StaticSeedFinder`, which results in the following error when
running this test:
def mark_failed(self, seed):
> self._seeds.remove(seed)
E ValueError: list.remove(x): x not in list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in
StaticSeedFinder, which results in the following error whenrunning this test:
I'm not sure if the bug is in
mark_failed(addingif seed in self._seeds:would fix it), or inadd_node(perhaps discovered nodes should get added toself._seedsinstead ofself.candidates?), so I'm only providing a test at this moment.