Add exception to expose existing (persistent) subscription response - #137
Open
vtermanis wants to merge 1 commit into
Open
Add exception to expose existing (persistent) subscription response#137vtermanis wants to merge 1 commit into
vtermanis wants to merge 1 commit into
Conversation
vtermanis
commented
Apr 12, 2019
Contributor
- Distinguish creation failure from already-existing state
- Distinguish creation failure from already-existing state
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 85.31% 85.25% -0.07%
==========================================
Files 8 8
Lines 2254 2258 +4
Branches 238 239 +1
==========================================
+ Hits 1923 1925 +2
- Misses 275 276 +1
- Partials 56 57 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@bobthemighty I probably won't have time to make additional changes here if required before next Wednesday so please do feel free to amend where necessary (as well as in the other PR). I presumse codecov "fails" because there's no test case for actual subscription failure (simulation) and hence that branch is no longer exercised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.