Skip to content

e2e: fix the Go watch-set loader reconnect flake #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkeroack merged 1 commit into from
Oct 6, 2026
Merged

e2e: fix the Go watch-set loader reconnect flake #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clients/go/e2e/resilientwatch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,12 @@ func TestE2EWatchSetLoaderRebuildsFromTruthOnReconnect(t *testing.T) {
if err != nil {
break
}
if m, ok := ev.(*satdevents.ScriptMatched); ok && satdevents.DisplayHex(m.Txid) == txid {
// Wait for the CONFIRMED match, as primeRW does: only it carries
// a cursor. Stopping at the mempool match cut the transport, most
// runs, before the confirmed one reached the pump. The reconnect
// then had no resume cursor, sent no SetCursor, and the wait for
// CursorAccepted below saw only heartbeats until it timed out.
if m, ok := ev.(*satdevents.ScriptMatched); ok && m.Confirmed && satdevents.DisplayHex(m.Txid) == txid {
registered = true
break
}
Expand Down
Loading