Repository navigation
ci: run Tests and Lint on pushes to release branches - #913
Merged
Merged
Conversation
ci.yml ran on pull requests and on pushes to master only, so nothing tested release/0.6 after a merge. A PR is tested as head-merged-into-base at event time, and an --admin merge can land on top of a fix that merged after that run, so the 0.6.x branch could reach a tag with a combination no CI run had built. Pushes to release/** now get the same Tests and Lint run as master pushes. seed-cache stays master-only, and push runs are still never cancelled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 6, 2026
bkeroack
added a commit
that referenced
this pull request
Oct 6, 2026
ci.yml ran on pull requests and on pushes to master only, so nothing tested release/0.6 after a merge. A PR is tested as head-merged-into-base at event time, and an --admin merge can land on top of a fix that merged after that run, so the 0.6.x branch could reach a tag with a combination no CI run had built. Pushes to release/** now get the same Tests and Lint run as master pushes. seed-cache stays master-only, and push runs are still never cancelled. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 85b704e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.ymlruns on pull requests and on pushes tomaster, so nothing testsrelease/0.6after a merge. A PR is tested as head-merged-into-base when its checks run. With--adminmerges, a PR's green checks can predate another fix that merged into the branch after them, and 0.6.x is tagged from that branch. #898 and #899 merged that way today, so their combined tree was only checked locally.Change
push.branchesgains'release/**', so every push to a release branch gets the sameTestsandLintrun as a push tomaster.seed-cachestays master-only (its ownif:). Push runs are still never cancelled, since the concurrency group is per ref andcancel-in-progressis for pull requests only.Nothing in
ci.ymlpublishes, so a release-branch push only builds and tests. The oldrelease/0.3.1andrelease/0.3.2branches match too, but nothing pushes to them.Verifying
A push run uses the
ci.ymlin the pushed commit, so merging this PR intorelease/0.6is the first push it triggers: aCIrun onrelease/0.6should appear for the merge commit. The YAML parses (push.branchesis['master', 'release/**']);actionlintruns in this PR'sLintjob.Follow-up
The same change goes to
masterafter this merges, sorelease/0.7inherits it when it is cut.🤖 Generated with Claude Code