fix: tolerate OAuth token sets missing token_type/scope (EPICSHOP-HG) - #654
Merged
Merged
Conversation
Incomplete local auth token metadata was failing Zod parse on DB read, which treated the whole data file as corrupted and wiped preferences. Default token_type/scope like CLI auth already does when persisting. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kentcdodds
marked this pull request as ready for review
August 13, 2026 23:47
|
View your CI Pipeline Execution ↗ for commit 3501956
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sentry EPICSHOP-HG reported a handled
ZodErrorwhile reading localdata.jsonduringwarmCache→getAuthInfo→readDb.The stored auth entry for
www.epicreact.devhad an OAuthtokenSetwithaccess_tokenbut missingtoken_typeandscope. Those fields are optional in OAuth responses; the CLI already defaults them when saving (Bearer/''), but the shared DB schema required both strings. Parse failure was treated as a corrupted database file (retries, Sentry capture, move to.bkp), which wipes preferences along with auth.Fix
token_typeto'Bearer'andscopeto''inTokenSetSchema(workshop-utils + CLI auth schema).setAuthInfoon write.Risk
Low — isolated schema/default change with tests; preserves existing complete token sets.
Testing / CI
nx run @epic-web/workshop-utils:test -- db-auth-token-setandnpm run validateMerge note
Autonomous squash-merge was blocked by
epicweb-devOAuth App access restrictions; PR is ready for Kent to merge. After merge, resolve EPICSHOP-HG in the squash commit.