fix: filter Firefox PiP user-activation Sentry noise (EPICSHOP-HE) - #651
Merged
Merged
Conversation
Extend the client NotAllowedError filter and ignoreErrors for Firefox's "Picture-in-Picture requires user activation" rejection from media-chrome, and swallow requestPictureInPicture rejections in keyboard shortcuts. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
August 8, 2026 09:17
|
View your CI Pipeline Execution ↗ for commit 7c32712
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotAllowedError: Picture-in-Picture requires user activationwhen transient user activation is missing; media-chrome's PiP button surfaces this as an unhandled rejection (EPICSHOP-HE).NotAllowedErrorfilter andignoreErrorsto cover that Firefox signature (Chrome's "processing a Picture-in-Picture request" was already filtered).requestPictureInPicture()rejections in keyboard shortcuts (i) the same way we already swallowexitPictureInPicture().Test plan
packages/workshop-app/tests/sentry-filters.test.tsfor the Firefox messagenpm run validatee26e7d9f