Repository navigation
chore: pin rust toolchain to 1.99 instead of floating stable - #44
Merged
Merged
Conversation
A new stable ships new clippy lints; with -D warnings that turned main red the day 1.99 released (#43). The MSRV job now runs cargo +1.88 explicitly so the toolchain file does not override it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjFfmjfKnj4sBd2B6YAjPj
|
ePHPm Preview — removed Preview deployment has been torn down. |
|
ePHPm Preview — deployed (health check pending)
Preview updates automatically on each push to this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI installed `stable` and so picked up every new Rust release with no review. Rust 1.99 added new clippy lints, and with `-D warnings` main went red the day it shipped (#43).
This adds `rust-toolchain.toml` pinned to `1.99`. Patch releases (1.99.x) still come in automatically, but a new minor version now needs its own PR.
The MSRV job changes too. rustup reads `rust-toolchain.toml` before the toolchain that `dtolnay/rust-toolchain` installs. Without a change, the `msrv (1.88)` job would quietly check on 1.99. It now runs `cargo +1.88 check` explicitly.
Matching ePHPm PR: ephpm/ephpm#537.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QjFfmjfKnj4sBd2B6YAjPj