Skip to content

Speedup Version(short, short, short, string) constructor #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buhaiovos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speedup Version(short, short, short, string) constructor #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions sdmx30-infomodel/src/main/java/com/epam/jsdmx/infomodel/sdmx30/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.epam.jsdmx.infomodel.sdmx30;

import java.util.Arrays;
import java.util.Objects;
import java.util.Optional;
import java.util.regex.Pattern;

Expand All @@ -20,10 +21,11 @@ public class Version {

public static final Pattern PATTERN = Pattern.compile("\\d+\\.\\d+(\\.\\d+(-\\w+)?)?");

private final String value;
private final short[] componentsArray;
private final String extension;

private String value;

public Version(Version other) {
this.value = other.value;
this.componentsArray = Arrays.copyOf(other.componentsArray, other.componentsArray.length);
Expand All @@ -38,7 +40,6 @@ private Version(String version) {

private Version(short major, short minor, short patch, String extension) {
validateComponents(major, minor, patch);
this.value = major + "." + minor + "." + patch + (StringUtils.isNotEmpty(extension) ? "-" + extension : "");
this.componentsArray = new short[]{major, minor, patch};
this.extension = extension;
}
Expand Down Expand Up @@ -85,7 +86,11 @@ private short[] splitIntoComponents(String version) {
}

public String getValue() {
return this.value;
if (this.value == null) {
// may be null only for 3-component version
value = componentsArray[0] + "." + componentsArray[1] + "." + componentsArray[2] + (StringUtils.isNotEmpty(extension) ? "-" + extension : "");
}
return value;
}

public short getMajor() {
Expand Down Expand Up @@ -120,25 +125,23 @@ public boolean isStable() {

@Override
public String toString() {
return value;
return getValue();
}

@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (!(o instanceof Version)) {
if (o == null || getClass() != o.getClass()) {
return false;
}

Version version = (Version) o;

return value.equals(version.value);
return Arrays.equals(componentsArray, version.componentsArray) && Objects.equals(extension, version.extension);
}

@Override
public int hashCode() {
return value.hashCode();
int result = Arrays.hashCode(componentsArray);
result = 31 * result + Objects.hashCode(extension);
return result;
}
}
Loading