Skip to content

Fix toString implementation of identifiable reference (#77) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buhaiovos merged 1 commit into from
Nov 19, 2025
Merged

Fix toString implementation of identifiable reference (#77) #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...odel/src/main/java/com/epam/jsdmx/infomodel/sdmx30/IdentifiableArtefactReferenceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public IdentifiableArtefactReferenceImpl clone() {

@Override
public String toString() {
return super.toString();
String superString = super.toString();
return superString + "." + itemId;
}
}
20 changes: 20 additions & 0 deletions .../src/test/java/com/epam/jsdmx/infomodel/sdmx30/IdentifiableArtefactReferenceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package com.epam.jsdmx.infomodel.sdmx30;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;

class IdentifiableArtefactReferenceImplTest {
@Test
void testToString_happy() {
var subject = new IdentifiableArtefactReferenceImpl("id", "organisation", "1.0.0", StructureClassImpl.CONCEPT, "itemId");

Assertions.assertThat(subject.toString()).isEqualTo("Concept=organisation:id(1.0.0).itemId");
}

@Test
void testToString_itemIdIsNull() {
var subject = new IdentifiableArtefactReferenceImpl("id", "organisation", "1.0.0", StructureClassImpl.CONCEPT, null);

Assertions.assertThat(subject.toString()).isEqualTo("Concept=organisation:id(1.0.0).null");
}
}