fix: rename owner_sub to owner_user_id in OBO credentials API #1736#1737
Merged
DmytroZaichenkoDev merged 1 commit intoJul 20, 2026
Merged
Conversation
DmytroZaichenkoDev
requested review from
Oleksii-Klimov and
astsiapanay
as code owners
July 20, 2026 09:09
This comment has been minimized.
This comment has been minimized.
…#1736 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DmytroZaichenkoDev
force-pushed
the
fix/issue-1736-owner-user-id-rename
branch
from
July 20, 2026 09:19
e16ffb6 to
3c958c8
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Oleksii-Klimov
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the credential-owner field of
POST /v1/ops/external-service/obo-credentialsfromowner_subtoowner_user_id. The expected value is the user id as DIAL resolves it from the identity provider configuration (userIdPath), which is not necessarily the JWTsubclaim — with some identity providers (e.g. Azure AD, wheresubdiffers per client application) passing the literalsubfails with 404 even though the owner is signed in.Applicable issues
owner_subtoowner_user_idin on-behalf-of credentials API #1736Description of changes
OboCredentialsRequest: field renamed toownerUserId, accepted JSON names areowner_user_id/ownerUserId(the oldowner_subname is no longer accepted), validation message updated.ExternalServiceCredentialsController,CredentialsLocatorFactory,CredentialsDescriptorFactory,ResourceCredentialsService,UserExternalServiceService) and updated javadoc wording from "owner sub" to "owner user id".owner_sub=→owner_user_id=in theobo_credential_retrievalevent.docs/open_api_core.yaml(OboCredentialsRequest.ownerSub→ownerUserId).ExternalServiceOboCredentialsApiTestaccordingly.Related: #1735 (expose the resolved user id via
GET /v1/user/info— separate PR).Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
🤖 Generated with Claude Code