Skip to content

fix: rename owner_sub to owner_user_id in OBO credentials API #1736#1737

Merged
DmytroZaichenkoDev merged 1 commit into
developmentfrom
fix/issue-1736-owner-user-id-rename
Jul 20, 2026
Merged

fix: rename owner_sub to owner_user_id in OBO credentials API #1736#1737
DmytroZaichenkoDev merged 1 commit into
developmentfrom
fix/issue-1736-owner-user-id-rename

Conversation

@DmytroZaichenkoDev

@DmytroZaichenkoDev DmytroZaichenkoDev commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Renames the credential-owner field of POST /v1/ops/external-service/obo-credentials from owner_sub to owner_user_id. The expected value is the user id as DIAL resolves it from the identity provider configuration (userIdPath), which is not necessarily the JWT sub claim — with some identity providers (e.g. Azure AD, where sub differs per client application) passing the literal sub fails with 404 even though the owner is signed in.

Applicable issues

Description of changes

  • OboCredentialsRequest: field renamed to ownerUserId, accepted JSON names are owner_user_id / ownerUserId (the old owner_sub name is no longer accepted), validation message updated.
  • Renamed the corresponding Java identifiers along the OBO path (ExternalServiceCredentialsController, CredentialsLocatorFactory, CredentialsDescriptorFactory, ResourceCredentialsService, UserExternalServiceService) and updated javadoc wording from "owner sub" to "owner user id".
  • Audit log key renamed: owner_sub=owner_user_id= in the obo_credential_retrieval event.
  • Regenerated docs/open_api_core.yaml (OboCredentialsRequest.ownerSubownerUserId).
  • Updated ExternalServiceOboCredentialsApiTest accordingly.

Related: #1735 (expose the resolved user id via GET /v1/user/info — separate PR).

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

🤖 Generated with Claude Code

@ai-dial-actions

This comment has been minimized.

…#1736

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@DmytroZaichenkoDev
DmytroZaichenkoDev force-pushed the fix/issue-1736-owner-user-id-rename branch from e16ffb6 to 3c958c8 Compare July 20, 2026 09:19
@ai-dial-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@DmytroZaichenkoDev
DmytroZaichenkoDev merged commit 069cbd6 into development Jul 20, 2026
9 checks passed
@DmytroZaichenkoDev
DmytroZaichenkoDev deleted the fix/issue-1736-owner-user-id-rename branch July 20, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename owner_sub to owner_user_id in on-behalf-of credentials API

3 participants