feat: share a skill as a whole #1641#1734
Merged
Merged
Conversation
Add tests verifying a shared skill's access can be explicitly revoked and that deleting a shared skill cleans up its share metadata, on top of the existing generic sharing support for the SKILL resource type.
Oleksii-Klimov
approved these changes
Jul 17, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage confirming that the SKILL resource type is fully integrated with the existing sharing mechanism: a skill can be shared as a whole unit, files beneath it inherit the granted access, and both explicit revocation and whole-resource deletion clean up the share metadata.
Applicable issues
Description of changes
SKILL(resource type registration, share-limits table entry, and the generic parent-folder permission inheritance used byShareService/AccessService) already landed via prior work on the folder-as-resource epic (Folder-as-resource foundation: SKILL type, v2 route, whole-resource PUT/GET #1634, Folder-as-resource: access control integration for skills #1640).SkillResourceApiTest.testRevokeSharedAccess: shares a whole skill resource, accepts the invitation, verifies access, then explicitly revokes it via/v1/ops/resource/share/revokeand confirms access to the skill and its files is removed.SkillResourceApiTest.testCleanUpShareAccessWhenOnResourceDeletion: shares a skill, accepts, deletes it, recreates a skill at the same path, and confirms the previous share does not carry over — verifying the existing whole-resource DELETE cleanup (Folder-as-resource: whole-resource DELETE via tombstone marker state #1635) applies to SKILL.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.