feat: folder-as-resource limits & skill validation #1637#1730
Merged
Conversation
…er resources #1637 Add configurable maxFiles/maxTotalBytes/maxFileSizeBytes settings for folder-as-resource complex resources, enforced on whole-resource and single-file PUT so a rejection leaves nothing observable and bounds lock-hold time. Consolidate per-file size/etag tracking into a single fileMetadata map on the .dial-resource marker.
This comment has been minimized.
This comment has been minimized.
Oleksii-Klimov
approved these changes
Jul 17, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounds abuse and enforces skill structural validity with configurable per-resource limits on folder-as-resource complex resources (e.g. skills), and confirms skill validation errors are consistently reported as
400with a clear message.Applicable issues
Description of changes
ComplexResourceService.Settings(maxFiles,maxTotalBytes,maxFileSizeBytes) with sensible defaults (100 files / 16 MiB / 1 MiB), wired via a newcomplexResourcestatic settings block inAiDial.javaandaidial.settings.json(main + test).ComplexResourceService.put) before any write or lock is taken, and on single-file PUT (putFile/copyOnWrite) before the version copy, so a rejection leaves no observable version/marker and bounds lock-hold time.files/fileSizesmaps into a singlefileMetadata: Map<String, ResourceFileMetadata>field onFolderResourceMarker, so per-file size/etag are tracked together andmaxTotalBytescan be checked on a single-file mutation without re-reading existing file content.SkillHandler's existing validation (missingSKILL.md, unparseable/incomplete frontmatter) already consistently throwsHttpException(BAD_REQUEST, ...)with a clear message — no changes needed there.README.md.SkillResourceApiTest) and the service level (ComplexResourceServiceTest), verifying rejected writes leave nothing observable.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.