feat: dial-unified-config — dial-cli (Picocli + Quarkus CLI)#1531
Open
siarhei-fedziukovich wants to merge 253 commits into
Open
feat: dial-unified-config — dial-cli (Picocli + Quarkus CLI)#1531siarhei-fedziukovich wants to merge 253 commits into
siarhei-fedziukovich wants to merge 253 commits into
Conversation
siarhei-fedziukovich
requested review from
Oleksii-Klimov and
astsiapanay
as code owners
May 11, 2026 19:55
Contributor
Author
|
/deploy-review
|
Contributor
Author
|
/deploy-review
|
Contributor
Author
|
/deploy-review
|
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
2 times, most recently
from
May 25, 2026 15:21
ee00e6c to
a2400d6
Compare
Contributor
|
/deploy-review
|
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
from
June 1, 2026 19:06
d1b1754 to
a4fa152
Compare
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
from
June 3, 2026 16:54
38e00fe to
29beb1a
Compare
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
from
June 8, 2026 10:16
6e1774e to
56c2752
Compare
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
from
June 8, 2026 20:29
f76793b to
d8628cc
Compare
Contributor
|
/deploy-review
|
Add .classpath, .factorypath, .project, .settings/ to .gitignore. These are generated by Eclipse and the JDTLS language server (used by Claude Code's LSP integration), should not be tracked. Existing entries cover IntelliJ (.idea/) and VS Code (.vscode/). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The .claude/commands/review-unified-config.md file is a personal/local slash command, not part of the shared MVP tooling. Gitignored to avoid accidental inclusion in commits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Refine the branch-hygiene policy in IMPLEMENTATION.md §3.2 / §9. Default remains rebase (linear history; force-push; sub-branches rebase onto new tip). Per-sync merge override is now allowed when situational — early in MVP with few slices in flight, or when conflicts resolve more cleanly with a merge commit. Late in MVP, prefer rebase to keep history readable for the final big-PR review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Update expected outputs throughout dial-cli-devops-presentation.md to match what the implementation actually produces: plain-text Created/Updated/Deleted messages, `applied: N, failed: N` for apply, raw JSON envelope for dry-run promote, correct error message strings, exit code 2 scoped to HTTP 400/422, file-sourced key list behaviour, settings delete idempotency note, env use confirmation message, and validate subcommand in Quick Reference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ADME Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
KirylKurnosenka
force-pushed
the
feature/unified-config-cli
branch
from
June 9, 2026 10:13
1524d34 to
95eb970
Compare
Contributor
|
/deploy-review
|
Two bugs caused inconsistent placeholder resolution in `dial-cli apply`:
1. Entity names containing `${params.*}` (e.g. `models/public/${params.model_name}`)
were stored as raw strings in the entity context, so `${entity.name}` in template
fields resolved to the literal placeholder string rather than the actual value.
Fields inside `!for` loops coincidentally got a second substitution pass and
appeared resolved, while non-loop fields did not — producing inconsistent output.
Fix: resolve the manifest name against params+vars before building entity context
and writing the apply envelope (`TemplateResolver.resolveString`,
`ApplyCommand`, `ManifestLoader.canonicalIdOf` overload for `fetchCurrentForPatch`).
2. `ControlFlowExpander.substitutePlaceholders` substituted `${...}` in object values
but silently passed keys through unchanged, leaving map keys such as
`"models/public/${params.model_name}"` unresolved in the output spec.
Fix: apply `sub.substitute()` to each key as well as its value.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
/deploy-review
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
ApplyCommand.fetchCurrentForPatch now removes name/status/validationWarnings from the server GET response before JsonMergePatch.apply, preventing a 400 from the server when the merged spec is sent back via /v1/admin/apply. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
/deploy-review
|
Contributor
|
/deploy-review
|
This comment has been minimized.
This comment has been minimized.
Reorganise the cli module from a flat root package into a clean layered structure (command → service → client/data/exception) so responsibilities are explicit and dependency direction is one-way: command/ – picocli commands + converters + output renderers command/output/ – EntityRenderer, Json/Yaml/TableEntityRenderer service/ – EntityReader, EntityWriter, EntityDiff, EnvResolver service/auth/ – ApiKeyResolver, PasswordPrompter (was auth/) service/json/ – JsonMergePatch, JsonPatcher, JsonDiff service/manifest/ – Manifest, ManifestLoader, OverlayResolver service/template/ – template DSL pipeline (was template/) client/ – CliHttpClient (was http/) data/ – CliProfile, Environment, Defaults, Auth, ProfileLoader, YamlPatcher, OutputFormat exception/ – CliException, CliConfigException, ManifestParseException, NetworkException, TemplateException config/ – DialCliFactory, CliConfiguration (wiring only) No logic changes — pure package moves, package-declaration updates, and import fixes. New types introduced solely as extraction vehicles: • Manifest – extracted from ManifestLoader inner record • CliOptionsDto – DTO replacing direct DialCli dependency in service layer • OutputFormatDto / OutputFormatResolver – service-layer output-format handling Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
/deploy-review
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
/deploy-review
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
/deploy-review
|
…n fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Dependency ReviewThe following issues were found:
Vulnerabilitiessettings.gradle
License Issuessettings.gradle
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
|
/deploy-review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.