feat: support structured logging#503
Open
adubovik wants to merge 3 commits into
Open
Conversation
Migrate to aidial-sdk 0.38.0, which adds configure_root_logger/LogConfig for structured logging. Set DIAL_SDK_LOG_FORMAT=json to switch from the default text format to JSON. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured (JSON) logging support by migrating to
aidial-sdk0.38.0, which introducesconfigure_root_logger/LogConfigfor configuring the root logger's format.aidial-sdkto0.38.0.configure_loggers()in log_config.py to use the SDK'sconfigure_root_logger/LogConfiginstead of hand-rolled root logger setup, while preserving the existing health-check log filtering and per-logger level configuration.DIAL_SDK_LOG_FORMAT/DIAL_SDK_TEXT_LOG_FORMAT/DIAL_SDK_JSON_LOG_FORMATenv vars in a new Logging section of the README.To enable JSON logs:
This is analogous to epam/ai-dial-adapter-bedrock#466, which added the same capability to the Bedrock adapter.
Test plan
make lintmake testconfigure_loggers(), including that health-check request filtering still works