Refactor cuiman authentication configuration - #192
Draft
forman wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176.
This PR separates proprietary login from standards-based OAuth2 authentication and makes the configuration shape explicit per authentication mechanism.
See also required eo-tools/eozilla-app#76
Changes
nonebasictokenloginoauth2api-keyOAuth2GrantTypesupport forpasswordandclient_credentials.auth_url→login_urlortoken_urltoken→access_tokentoken_header→access_token_headercuiman configure, CLI options, environment-variable handling, token refresh, and client integration.Configuration migration
Compatibility is intentionally limited:
Legacy flat
none,basic,token, andapi-keyfile configurations are converted when read.A legacy flat
loginconfiguration containingauth_urlfails with:Legacy configuration format detected, please run 'cuiman configure'This avoids incorrectly treating a proprietary login flow as OAuth2.
Validation
cuiman: 303 tests passed; Ruff and Mypy passed.eozilla-app: 164 tests passed; TypeScript typecheck and ESLint passed.Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mddocs/*