fix redudant login prompt from eozilla app - #183
Merged
TejasMorbagal merged 3 commits intoJul 31, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…udant-interactive-login-for-app
freds-dev
reviewed
Jul 31, 2026
freds-dev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Steps I did to verify:
- Authenticating to the S2GOS Keycloak token endpoint with
cuiman configure, usingauth_type: loginandclient ID: cuiman. - Saving the resulting access token in a temporary local config.
- Launching the app with that config via
cuiman show-app. - Confirming the app connected to S2GOS immediately, without redirecting to Keycloak or prompting you to log in again.
Just one thing: After the token expired there is no refresh so the token won't work anymore and the requests return Jwt is expired.
Collaborator
Author
Yes, refresh token won't work. The user has to re-login. |
freds-dev
self-requested a review
July 31, 2026 09:05
freds-dev
approved these changes
Jul 31, 2026
TejasMorbagal
deleted the
TejasMorbagal/fix-redudant-interactive-login-for-app
branch
July 31, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added _effective_auth_type(): when a client config has auth_type="login" and already holds a resolved token (which is always true by the time show_app() runs), it's forwarded to the GUI as auth_type="token" instead of "login". The GUI's authType: "token" path just attaches the existing bearer token; "login" was making it discard that token and force a fresh interactive OAuth2/PKCE redirect.
Checklist (strike out non-applicable):
CHANGES.md* [ ] Related issue exists and is referred to in the PR description andCHANGES.md* [ ] Added docstrings and API docs for any new/modified user-facing classes and functions* [ ] Changes/features documented indocs/*