This repository was archived by the owner on May 26, 2023. It is now read-only.
New opcodes - #410
Open
Mayur1496 wants to merge 8 commits into
Open
Conversation
Mayur1496
marked this pull request as ready for review
September 24, 2020 11:50
yxliang01
suggested changes
Nov 6, 2020
yxliang01
left a comment
yxliang01
left a comment
Contributor
There was a problem hiding this comment.
Just small bit and this is ready for merging :)
| else: | ||
| raise ValueError('STACK underflow') | ||
| elif opcode == "SHL": | ||
| if len(stack) > 1: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(stack) > 1: | |
| if len(stack) >= 2: |
For readability
| else: | ||
| raise ValueError('STACK underflow') | ||
| elif opcode == "SHR": | ||
| if len(stack) > 1: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(stack) > 1: | |
| if len(stack) >= 2: |
| else: | ||
| raise ValueError('STACK underflow') | ||
| elif opcode == "EXTCODEHASH": | ||
| if len(stack) > 0: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(stack) > 0: | |
| if len(stack) >= 1: |
| if len(stack) > 0: | ||
| global_state["pc"] = global_state["pc"] + 1 | ||
| stack.pop(0) | ||
| new_var_name = "IH_codehash" |
Contributor
There was a problem hiding this comment.
For better modelling, can you create a variable for each requested address?
| else: | ||
| raise ValueError('STACK underflow') | ||
| elif opcode == "CREATE2": | ||
| if len(stack) > 3: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(stack) > 3: | |
| if len(stack) >= 4: |
| raise ValueError('STACK underflow') | ||
| elif opcode == "SHL": | ||
| if len(stack) > 1: | ||
| global_state["pc"] = global_state["pc"] + 1 |
Contributor
There was a problem hiding this comment.
Use += 1 for all such occurrences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces support for new opcodes :