fix: target branch in go bench - #9884
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9884 +/- ##
==========================================
+ Coverage 81.24% 81.26% +0.02%
==========================================
Files 263 263
Lines 40747 40859 +112
==========================================
+ Hits 33103 33206 +103
- Misses 7644 7653 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
need to backport? |
Yes, needs for v1.8, v1.9. I'll create backport PRs. |
What this PR does / why we need it:
go-benchmark-testfails in release branch because of go version diff.Ref: https://github.com/envoyproxy/gateway/actions/runs/33142425720/job/98772674274?pr=9878
The comparison script hardcodes
origin/mainas the baseline:Meanwhile setup-deps installs Go from the PR branch's
go.modvia actions/setup-go (go-version-file: go.mod), which also setsGOTOOLCHAIN=local. So on a release/v1.9 PR the runner gets Go 1.26.7, then checks out main, which is now on Go 1.27.0.Even with a matching toolchain, comparing a release branch against main is not a meaningful baseline — main carries features the release branch does not.
Which issue(s) this PR fixes:
Fixes #
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.