Skip to content

fix: target branch in go bench - #9884

Merged
kkk777-7 merged 1 commit into
envoyproxy:mainfrom
kkk777-7:fix-go-bench-ci
Aug 28, 2026
Merged

fix: target branch in go bench#9884
kkk777-7 merged 1 commit into
envoyproxy:mainfrom
kkk777-7:fix-go-bench-ci

Conversation

@kkk777-7

@kkk777-7 kkk777-7 commented Aug 28, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

go-benchmark-test fails in release branch because of go version diff.
Ref: https://github.com/envoyproxy/gateway/actions/runs/33142425720/job/98772674274?pr=9878

The comparison script hardcodes origin/main as the baseline:

log "Switching to main branch..."
if ! git checkout origin/main --quiet; then

Meanwhile setup-deps installs Go from the PR branch's go.mod via actions/setup-go (go-version-file: go.mod), which also sets GOTOOLCHAIN=local. So on a release/v1.9 PR the runner gets Go 1.26.7, then checks out main, which is now on Go 1.27.0.

Even with a matching toolchain, comparing a release branch against main is not a meaningful baseline — main carries features the release branch does not.

Which issue(s) this PR fixes:

Fixes #


PR Checklist

  • Authorship & ownership: Coding agents / AI assistants are welcome, but I have reviewed every change, understand how and why it works, can explain and maintain it, and take full responsibility for this PR. I have not submitted generated output I do not understand.
  • DCO: All commits are signed off (git commit -s). See DCO: Sign your work.
  • API agreed first: If this PR contains API changes (changes under /api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.
  • Required checks pass: make generate gen-check, make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, but gen-check, lint, and coverage MUST pass.)
  • Tests added/updated: New/changed code is covered by appropriate tests. N/A if this PR does not contain code changes.
  • Docs: User-facing changes update the docs, either in this PR or a follow-up PR. N/A if this PR does not contain user-facing changes.
  • Release notes: For any non-trivial change, added a release-note fragment under release-notes/current/<section>/<pr-number>-<slug>.md (see release-notes/current/README.md for sections and naming). N/A if this PR does not contain non-trivial changes.
  • Generated files committed: Ran make gen-check and committed the result if API/helm charts/modules changed.
  • Scope & compatibility: The PR is reasonably scoped (no unrelated changes) and preserves backward compatibility, or any breaking change is called out above and documented in release-notes/current/breaking_changes/.
  • Codex review: Requested a Codex review and addressed all of its comments.
  • Copilot review: Requested a Copilot review and addressed all of its comments.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
kkk777-7 requested a review from a team as a code owner August 28, 2026 07:05
@netlify

netlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 94be09f
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a91333a64e98100076cbc86
😎 Deploy Preview https://deploy-preview-9884--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kkk777-7

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 94be09f924

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.26%. Comparing base (04838a7) to head (94be09f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9884      +/-   ##
==========================================
+ Coverage   81.24%   81.26%   +0.02%     
==========================================
  Files         263      263              
  Lines       40747    40859     +112     
==========================================
+ Hits        33103    33206     +103     
- Misses       7644     7653       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain

zirain commented Aug 28, 2026

Copy link
Copy Markdown
Member

need to backport?

@kkk777-7

Copy link
Copy Markdown
Member Author

need to backport?

Yes, needs for v1.8, v1.9. I'll create backport PRs.

@kkk777-7
kkk777-7 merged commit a7d698b into envoyproxy:main Aug 28, 2026
140 of 153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants