-
Notifications
You must be signed in to change notification settings - Fork 854
api: add ClientTrafficPolicy option to emit Retry-After header on rate-limit 429 responses #9770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devilleweppenaar
wants to merge
12
commits into
envoyproxy:main
Choose a base branch
from
devilleweppenaar:retry-after-header-ctp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
73b1add
chore: bump go-control-plane to pick up envoy retry-after field
devilleweppenaar e0baf11
api: add enableRetryAfterHeader to ClientTrafficPolicy headers
devilleweppenaar 9197ddd
feat(translator): wire enableRetryAfterHeader to rate limit filters
devilleweppenaar 6c60dad
test: cover enableRetryAfterHeader in gatewayapi and xds translator
devilleweppenaar ad23819
docs: add release note for enableRetryAfterHeader
devilleweppenaar 63f90a6
chore: regenerate helm-template golden output for new CRD field
devilleweppenaar 2d9dda3
chore: bump go-control-plane in extension-server example module
devilleweppenaar 29a11ce
chore: bump go-control-plane in test module
devilleweppenaar aa2ed08
api: simplify enableRetryAfterHeader doc comment
devilleweppenaar cb731e6
test(e2e): verify Retry-After on rate-limited 429 responses
devilleweppenaar 19668e1
docs: align enableRetryAfterHeader wording on 429 scope
devilleweppenaar a21c7cf
Merge branch 'main' into retry-after-header-ctp
devilleweppenaar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
internal/gatewayapi/testdata/clienttrafficpolicy-retryafterheader.in.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| clientTrafficPolicies: | ||
| - apiVersion: gateway.envoyproxy.io/v1alpha1 | ||
| kind: ClientTrafficPolicy | ||
| metadata: | ||
| namespace: envoy-gateway | ||
| name: target-gateway-1 | ||
| spec: | ||
| headers: | ||
| enableRetryAfterHeader: true | ||
| targetRef: | ||
| group: gateway.networking.k8s.io | ||
| kind: Gateway | ||
| name: gateway-1 | ||
| gateways: | ||
| - apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: Gateway | ||
| metadata: | ||
| namespace: envoy-gateway | ||
| name: gateway-1 | ||
| spec: | ||
| gatewayClassName: envoy-gateway-class | ||
| listeners: | ||
| - name: http-1 | ||
| protocol: HTTP | ||
| port: 80 | ||
| allowedRoutes: | ||
| namespaces: | ||
| from: Same | ||
| - name: http-2 | ||
| protocol: HTTP | ||
| port: 8080 | ||
| allowedRoutes: | ||
| namespaces: | ||
| from: Same |
192 changes: 192 additions & 0 deletions
192
internal/gatewayapi/testdata/clienttrafficpolicy-retryafterheader.out.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| clientTrafficPolicies: | ||
| - apiVersion: gateway.envoyproxy.io/v1alpha1 | ||
| kind: ClientTrafficPolicy | ||
| metadata: | ||
| name: target-gateway-1 | ||
| namespace: envoy-gateway | ||
| spec: | ||
| headers: | ||
| enableRetryAfterHeader: true | ||
| targetRef: | ||
| group: gateway.networking.k8s.io | ||
| kind: Gateway | ||
| name: gateway-1 | ||
| status: | ||
| ancestors: | ||
| - ancestorRef: | ||
| group: gateway.networking.k8s.io | ||
| kind: Gateway | ||
| name: gateway-1 | ||
| namespace: envoy-gateway | ||
| conditions: | ||
| - lastTransitionTime: null | ||
| message: Policy has been accepted. | ||
| reason: Accepted | ||
| status: "True" | ||
| type: Accepted | ||
| - lastTransitionTime: null | ||
| message: spec.targetRef is deprecated, use spec.targetRefs instead | ||
| reason: DeprecatedField | ||
| status: "True" | ||
| type: Warning | ||
| controllerName: gateway.envoyproxy.io/gatewayclass-controller | ||
| gateways: | ||
| - apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: Gateway | ||
| metadata: | ||
| name: gateway-1 | ||
| namespace: envoy-gateway | ||
| spec: | ||
| gatewayClassName: envoy-gateway-class | ||
| listeners: | ||
| - allowedRoutes: | ||
| namespaces: | ||
| from: Same | ||
| name: http-1 | ||
| port: 80 | ||
| protocol: HTTP | ||
| - allowedRoutes: | ||
| namespaces: | ||
| from: Same | ||
| name: http-2 | ||
| port: 8080 | ||
| protocol: HTTP | ||
| status: | ||
| listeners: | ||
| - attachedRoutes: 0 | ||
| conditions: | ||
| - lastTransitionTime: null | ||
| message: Sending translated listener configuration to the data plane | ||
| reason: Programmed | ||
| status: "True" | ||
| type: Programmed | ||
| - lastTransitionTime: null | ||
| message: Listener has been successfully translated | ||
| reason: Accepted | ||
| status: "True" | ||
| type: Accepted | ||
| - lastTransitionTime: null | ||
| message: Listener references have been resolved | ||
| reason: ResolvedRefs | ||
| status: "True" | ||
| type: ResolvedRefs | ||
| name: http-1 | ||
| supportedKinds: | ||
| - group: gateway.networking.k8s.io | ||
| kind: HTTPRoute | ||
| - group: gateway.networking.k8s.io | ||
| kind: GRPCRoute | ||
| - attachedRoutes: 0 | ||
| conditions: | ||
| - lastTransitionTime: null | ||
| message: Sending translated listener configuration to the data plane | ||
| reason: Programmed | ||
| status: "True" | ||
| type: Programmed | ||
| - lastTransitionTime: null | ||
| message: Listener has been successfully translated | ||
| reason: Accepted | ||
| status: "True" | ||
| type: Accepted | ||
| - lastTransitionTime: null | ||
| message: Listener references have been resolved | ||
| reason: ResolvedRefs | ||
| status: "True" | ||
| type: ResolvedRefs | ||
| name: http-2 | ||
| supportedKinds: | ||
| - group: gateway.networking.k8s.io | ||
| kind: HTTPRoute | ||
| - group: gateway.networking.k8s.io | ||
| kind: GRPCRoute | ||
| infraIR: | ||
| envoy-gateway/gateway-1: | ||
| proxy: | ||
| listeners: | ||
| - name: envoy-gateway/gateway-1/http-1 | ||
| ports: | ||
| - containerPort: 10080 | ||
| name: http-80 | ||
| protocol: HTTP | ||
| servicePort: 80 | ||
| - name: envoy-gateway/gateway-1/http-2 | ||
| ports: | ||
| - containerPort: 8080 | ||
| name: http-8080 | ||
| protocol: HTTP | ||
| servicePort: 8080 | ||
| metadata: | ||
| labels: | ||
| gateway.envoyproxy.io/owning-gateway-name: gateway-1 | ||
| gateway.envoyproxy.io/owning-gateway-namespace: envoy-gateway | ||
| ownerReference: | ||
| kind: GatewayClass | ||
| name: envoy-gateway-class | ||
| name: envoy-gateway/gateway-1 | ||
| namespace: envoy-gateway-system | ||
| xdsIR: | ||
| envoy-gateway/gateway-1: | ||
| accessLog: | ||
| json: | ||
| - path: /dev/stdout | ||
| globalResources: | ||
| proxyServiceCluster: | ||
| metadata: | ||
| kind: Service | ||
| name: envoy-envoy-gateway-gateway-1-196ae069 | ||
| namespace: envoy-gateway-system | ||
| sectionName: "8080" | ||
| name: envoy-gateway/gateway-1 | ||
| settings: | ||
| - addressType: IP | ||
| endpoints: | ||
| - host: 7.6.5.4 | ||
| port: 8080 | ||
| zone: zone1 | ||
| metadata: | ||
| kind: Service | ||
| name: envoy-envoy-gateway-gateway-1-196ae069 | ||
| namespace: envoy-gateway-system | ||
| sectionName: "8080" | ||
| name: envoy-gateway/gateway-1 | ||
| protocol: TCP | ||
| http: | ||
| - address: 0.0.0.0 | ||
| externalPort: 80 | ||
| headers: | ||
| enableRetryAfterHeader: true | ||
| withUnderscoresAction: RejectRequest | ||
| hostnames: | ||
| - '*' | ||
| metadata: | ||
| kind: Gateway | ||
| name: gateway-1 | ||
| namespace: envoy-gateway | ||
| sectionName: http-1 | ||
| name: envoy-gateway/gateway-1/http-1 | ||
| path: | ||
| escapedSlashesAction: UnescapeAndRedirect | ||
| mergeSlashes: true | ||
| port: 10080 | ||
| - address: 0.0.0.0 | ||
| externalPort: 8080 | ||
| headers: | ||
| enableRetryAfterHeader: true | ||
| withUnderscoresAction: RejectRequest | ||
| hostnames: | ||
| - '*' | ||
| metadata: | ||
| kind: Gateway | ||
| name: gateway-1 | ||
| namespace: envoy-gateway | ||
| sectionName: http-2 | ||
| name: envoy-gateway/gateway-1/http-2 | ||
| path: | ||
| escapedSlashesAction: UnescapeAndRedirect | ||
| mergeSlashes: true | ||
| port: 8080 | ||
| readyListener: | ||
| address: 0.0.0.0 | ||
| ipFamily: IPv4 | ||
| path: /ready | ||
| port: 19003 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.