feat(telemetry): add prefix support for opentelemetry metrics - #9720
feat(telemetry): add prefix support for opentelemetry metrics#9720gray-oni wants to merge 10 commits into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4acb00d89f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
e954996 to
7335aa4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7335aa453d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9720 +/- ##
==========================================
+ Coverage 81.32% 81.34% +0.01%
==========================================
Files 264 264
Lines 40964 40969 +5
==========================================
+ Hits 33315 33326 +11
+ Misses 7648 7642 -6
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @zirain, I've seen you in the original issue discussion section. What could be the next steps for me to move forward with this change? |
|
It looks like some test suites are flaky and not representative |
|
/retest |
|
Tests are green. ready for review🙂 |
|
can we have a e2e for this? |
a6f8f21 to
0cca953
Compare
|
hey @zirain ,Thanks, an e2e test was added |
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
0cca953 to
53fd26e
Compare
|
@gray-oni can you |
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
Signed-off-by: SK <sergey@grayoni.tech>
f10263f to
5f487a8
Compare
|
hey @zirain, I had to resolve conflicts with main. could you trigger CI and re-approve PR if everything looks good? |
|
/retest |
1 similar comment
|
/retest |
What this PR does / why we need it:
feat(telemetry): add a new field to opentelemetry sink
This PR adds
prefixfield to opentelemetry sink settings. So an end-user can setup their envoy metrics with a custom prefix.Which issue(s) this PR fixes:
Fixes #6859
Example
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.