Skip to content

feat: request buffer limit - #8893

Open
zhaohuabing wants to merge 9 commits into
envoyproxy:mainfrom
zhaohuabing:api-request-buffer-limit
Open

feat: request buffer limit#8893
zhaohuabing wants to merge 9 commits into
envoyproxy:mainfrom
zhaohuabing:api-request-buffer-limit

Conversation

@zhaohuabing

@zhaohuabing zhaohuabing commented Apr 30, 2026

Copy link
Copy Markdown
Member

Implements: #8891
Release note: yes

@zhaohuabing
zhaohuabing requested a review from a team as a code owner April 30, 2026 01:58
@netlify

netlify Bot commented Apr 30, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit bc0b179
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a9510371ee58700081dd3cd
😎 Deploy Preview https://deploy-preview-8893--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.29%. Comparing base (4de02ef) to head (bc0b179).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/request_buffer.go 50.00% 2 Missing ⚠️
internal/gatewayapi/backendtrafficpolicy.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8893      +/-   ##
==========================================
+ Coverage   76.34%   81.29%   +4.95%     
==========================================
  Files         261      263       +2     
  Lines       44523    40867    -3656     
==========================================
- Hits        33989    33221     -768     
+ Misses       8285     7646     -639     
+ Partials     2249        0    -2249     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread api/v1alpha1/backendtrafficpolicy_types.go Outdated
@zhaohuabing
zhaohuabing requested a review from a team May 14, 2026 07:07
@github-actions github-actions Bot added the stale label Jun 13, 2026
@zhaohuabing zhaohuabing removed the stale label Jun 14, 2026
@zhaohuabing
zhaohuabing requested a review from yashbhuva June 22, 2026 07:26
@zhaohuabing zhaohuabing changed the title API: request buffer limit feat: request buffer limit Jun 22, 2026
@zhaohuabing
zhaohuabing force-pushed the api-request-buffer-limit branch from 8d0f19b to 0ac8c0d Compare June 22, 2026 08:22
@zhaohuabing
zhaohuabing requested a review from guydc June 22, 2026 10:51
@zhaohuabing zhaohuabing added this to the v1.9.0-rc.1 Release milestone Jun 22, 2026
@envoyproxy envoyproxy deleted a comment from github-actions Bot Jun 22, 2026
@zhaohuabing

Copy link
Copy Markdown
Member Author

retest

@zhaohuabing

Copy link
Copy Markdown
Member Author

/retest

@zhaohuabing

Copy link
Copy Markdown
Member Author

/retest

kkk777-7
kkk777-7 previously approved these changes Jul 10, 2026
@kkk777-7

Copy link
Copy Markdown
Member

LGTM, thanks!

@zhaohuabing
zhaohuabing requested review from a team and removed request for yashbhuva July 10, 2026 04:38
@zhaohuabing
zhaohuabing requested a review from kkk777-7 July 21, 2026 10:45
@zirain

zirain commented Jul 21, 2026

Copy link
Copy Markdown
Member

/retest

1 similar comment
@zirain

zirain commented Jul 21, 2026

Copy link
Copy Markdown
Member

/retest

Comment thread api/v1alpha1/backendtrafficpolicy_types.go Outdated
kkk777-7
kkk777-7 previously approved these changes Jul 22, 2026
@zhaohuabing
zhaohuabing requested review from kkk777-7 and zirain July 27, 2026 07:19
@zhaohuabing

Copy link
Copy Markdown
Member Author

/retest

@zhaohuabing
zhaohuabing marked this pull request as draft July 27, 2026 15:25
zhaohuabing and others added 7 commits August 24, 2026 19:07
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
@zhaohuabing
zhaohuabing force-pushed the api-request-buffer-limit branch from 92a8f25 to e92333b Compare August 25, 2026 02:16
@zhaohuabing
zhaohuabing marked this pull request as ready for review August 25, 2026 02:16
zirain
zirain previously approved these changes Aug 25, 2026
Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
Comment thread api/v1alpha1/backendtrafficpolicy_types.go Outdated
Pairs the two modes on a single axis (BufferAndLimit vs LimitOnly) and
clarifies in the godoc that limit applies in both modes, mode only
controls whether the gateway also buffers the whole body itself.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
@zhaohuabing

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@zhaohuabing

Copy link
Copy Markdown
Member Author

/retest

@zhaohuabing
zhaohuabing requested a review from arkodg September 1, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants