Make file descriptor limit adjustment portable - #46931
Merged
Merged
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setrlimit/getrlimit methods are not portable to Windows. Change API to be file limit specific and hide resource limit business in the platform specific code.
Coverage was lowered because set/getrlimit calls are no longer mocked and adding tests cases for then these calls fail is not feasible. This is not critical in the context of raising file descriptor soft limit.
Risk Level: none
Testing: unit tests
Docs Changes: no
Release Notes: no
Platform Specific Features: windows specific change.