istio stats: remove the dependency to the direction of factory context - #46906
Merged
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
Signed-off-by: wbpcode <wbphub@gmail.com>
Member
Author
|
/retest |
kyessenov
approved these changes
Aug 24, 2026
kyessenov
left a comment
kyessenov
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks for doing this.
Member
Author
|
cc @krinkinmu |
krinkinmu
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: istio stats: remove the dependency to the direction of factory context
Additional Description:
Now, the the istio stats won't depends on the factory context's trafficDirection(), like what we did at the #46893
After all these filters be updated, we could remove the direction() from the FactoryContext and the these filters also could works correctly at cross-listeners shared filter chain (FCDS).
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.