tls: fix stray dispatcher exit in ssl_socket_test - #46904
Merged
Conversation
singleWriteTest exited the dispatcher on the drain from closeSocket(), arming a loop exit while no loop ran and ending disconnect()'s run before the server saw the close. Also drain the read buffer so the server is not left permanently read disabled. Signed-off-by: Boteng Yao <botengyao@gmail.com>
botengyao
marked this pull request as ready for review
August 24, 2026 19:11
agrawroh
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
singleWriteTest exited the dispatcher on the drain from closeSocket(), arming a loop exit while no loop ran and ending disconnect()'s run before the server saw the close. Also drain the read buffer so the server is not left permanently read disabled.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]