fix: error on unsupported Anthropic tool types instead of silently dropping them - #2467
Open
hustxiayang wants to merge 1 commit into
Open
fix: error on unsupported Anthropic tool types instead of silently dropping them#2467hustxiayang wants to merge 1 commit into
hustxiayang wants to merge 1 commit into
Conversation
Signed-off-by: yxia216 <yxia216@bloomberg.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 159 159
Lines 22634 22638 +4
=======================================
+ Hits 19247 19251 +4
Misses 2219 2219
Partials 1168 1168 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
kanurag94
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When translating OpenAI tools to Anthropic, non-function tools (and function tools missing their definition) were silently skipped, so the model never received them and requests failed in confusing, hard-to-debug ways. This now returns a 400 (ErrInvalidRequestBody) with a clear message, matching the existing fail-closed behavior of the Gemini translator