fix: allow include_thoughts + thinking_level together for Gemini 3.x - #2433
Open
hustxiayang wants to merge 2 commits into
Open
fix: allow include_thoughts + thinking_level together for Gemini 3.x#2433hustxiayang wants to merge 2 commits into
include_thoughts + thinking_level together for Gemini 3.x#2433hustxiayang wants to merge 2 commits into
Conversation
hustxiayang
force-pushed
the
include-thoughts-fix
branch
from
July 27, 2026 17:57
6ad226b to
633f3c2
Compare
hustxiayang
marked this pull request as draft
July 27, 2026 18:01
Signed-off-by: yxia216 <yxia216@bloomberg.net>
hustxiayang
force-pushed
the
include-thoughts-fix
branch
from
July 27, 2026 18:50
633f3c2 to
18c5ed1
Compare
hustxiayang
marked this pull request as ready for review
July 27, 2026 18:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
==========================================
- Coverage 84.86% 84.85% -0.02%
==========================================
Files 154 154
Lines 22419 22423 +4
==========================================
+ Hits 19026 19027 +1
- Misses 2237 2239 +2
- Partials 1156 1157 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For GCP Vertex Gemini models, the gateway could not send
thinking_levelandinclude_thoughtsin the same request. As a result, callers usingreasoning_effort(which maps tothinking_level) could never receive thought summaries (reasoning_content), even though Gemini 3.x returns them when both fields are set.This pr is to allow a separate bool value:
include_thoughtsto determine whether it returns the thought summary.This would not break existing interface. There is a bit duplication with the budget setup, but it's fine as the budget setup is deprecating.