Skip to content

fix(extensionserver): validate rate limit service address - #2363

Merged
nacx merged 3 commits into
envoyproxy:mainfrom
0YHR0:fix/validate-ratelimit-service-address-2362
Aug 2, 2026
Merged

fix(extensionserver): validate rate limit service address#2363
nacx merged 3 commits into
envoyproxy:mainfrom
0YHR0:fix/validate-ratelimit-service-address-2362

Conversation

@0YHR0

@0YHR0 0YHR0 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description
Reject malformed quotaRateLimitServiceAddr values instead of treating every net.SplitHostPort error as a missing port. Hostnames and bare IPv6 literals continue to use the default port, while malformed addresses now fail fast during extension server startup.

Fixes #2362

Testing

  • go test ./internal/extensionserver -count=1

Signed-off-by: Yang Haoran <97868579@qq.com>
@0YHR0
0YHR0 requested a review from a team as a code owner July 14, 2026 09:17
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 14, 2026
@missBerg missBerg added bug Something isn't working area/quota Rate limiting, quota, token/cost accounting and attribution labels Jul 15, 2026
@0YHR0

0YHR0 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@missBerg pls take a look, thx :)

@nacx
nacx enabled auto-merge (squash) July 30, 2026 10:18
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.04%. Comparing base (25afc17) to head (4020347).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
- Coverage   85.05%   85.04%   -0.02%     
==========================================
  Files         159      159              
  Lines       22645    22649       +4     
==========================================
+ Hits        19261    19262       +1     
- Misses       2217     2219       +2     
- Partials     1167     1168       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nacx
nacx merged commit 3fc0f4f into envoyproxy:main Aug 2, 2026
34 checks passed
@dosubot

dosubot Bot commented Aug 2, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ai-gateway Add Dosu to your team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/quota Rate limiting, quota, token/cost accounting and attribution bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(extensionserver): reject malformed quota rate limit service addresses

4 participants